bpo-7769: enable xmlrpc.server.SimpleXMLRPCDispatcher.register_function used as decorator by zhangyangyu · Pull Request #231 · python/cpython

zhangyangyu · 2017-02-22T05:35:25Z

No description provided.

…ator

zhangyangyu · 2017-02-22T05:37:08Z

@briancurtin you are involved in the issue previously so I expect your opinion.

serhiy-storchaka · 2017-02-28T06:54:11Z

Doc/library/xmlrpc.server.rst


   Register a function that can respond to XML-RPC requests.  If *name* is given,
   it will be the method name associated with *function*, otherwise
   ``function.__name__`` will be used.  *name* can be either a normal or Unicode


"a normal or Unicode string" -- this is outdated in Python 3.

berkerpeksag · 2017-02-28T07:46:39Z

Doc/library/xmlrpc.server.rst

+   ``function.__name__`` will be used.  *name* is a string, and may contain
+   characters not legal in Python identifiers, including the period character.
+
+   From version 3.7, this method can also be used as a decorator.  When used as


"From version 3.7" is not needed. There is already a versionchanged directive below.

berkerpeksag · 2017-02-28T07:47:43Z

Doc/library/xmlrpc.server.rst

   # Print list of available methods
   print(s.system.listMethods())

+Since version 3.7, :meth:`register_function` can also be used as a decorator. The


"Since version 3.7" is not needed.

berkerpeksag · 2017-02-28T07:48:33Z

Doc/library/xmlrpc.server.rst

+previous server example can register functions in a decorator way::
+
+   from xmlrpc.server import SimpleXMLRPCServer
+   from xmlrpc.server import SimpleXMLRPCRequestHandler


Nitpick: I'd just merge two imports in one line.

This is to be consistent with previous examples. I don't want to change this alone. :-)

berkerpeksag · 2017-02-28T07:51:42Z

Doc/library/xmlrpc.server.rst

+
+       # Register a function under a different name, using
+       # register_function as a decorator. *name* can only be given
+       # as a keyword argument.


keyword -> keyword-only?

I think "can only be given as a keyword argument" is same as "keyword-only argument". :-)

I mean there is already a shorter way to say the same thing in Python.

I think the term "keyword-only" is applicable only to parameters, not arguments. Parameters can be positional-only (can't be defined in Python syntax), positional-or-keyword or keyword-only. Arguments can be positional or keyword.

I changed the sentence to “*name* is keyword-only". Since *name* is wrapped with asterisks, it's referring to a parameter.

But the name parameter is not keyword-only. It is positional-or-keyword.

The former wording looked correct to me, the changed wording don't.

berkerpeksag · 2017-02-28T07:52:04Z

Doc/library/xmlrpc.server.rst

+       # register_function as a decorator. *name* can only be given
+       # as a keyword argument.
+       @server.register_function(name='add')
+       def adder_function(x,y):


Missing space after comma.

berkerpeksag · 2017-02-28T07:52:52Z

Doc/library/xmlrpc.server.rst

+   class RequestHandler(SimpleXMLRPCRequestHandler):
+       rpc_paths = ('/RPC2',)
+
+   with SimpleXMLRPCServer(("localhost", 8000),


Nitpick: Use single quotes to be consistent with the rest of the example.

berkerpeksag · 2017-02-28T07:53:32Z

Doc/library/xmlrpc.server.rst

+       server.register_introspection_functions()
+
+       # Register pow() function; this will use the value of
+       # pow.__name__ as the name, which is just 'pow'.


the name -> *name*?

Hmm, it's not referring to the parameter here. So just leave it unchanged.

berkerpeksag · 2017-02-28T07:54:26Z

Doc/library/xmlrpc.server.rst

+   ``function.__name__`` will be used.  *name* is a string, and may contain
+   characters not legal in Python identifiers, including the period character.
+
+   From version 3.7, this method can also be used as a decorator.  When used as


"From version 3.7" is not needed.

zhangyangyu · 2017-02-28T09:14:56Z

Thanks @serhiy-storchaka and @berkerpeksag !

(Upstream is https://github.com/python/typing) - Add TYPE_CHECKING (false at runtime, true in type checkers) (upstream python#230). - Avoid error on Union[xml.etree.cElementTree.Element, str] (upstream python#229). - Repr of Tuple[()] should be 'Tuple[()]' (upstream python#231). - Add NewType() (upstream python#189).

Replace "https://bitbucket.org/stackless-dev/stackless" by "https://github.com/stackless-dev/stackless".

Replace "https://bitbucket.org/stackless-dev/stackless" by "https://github.com/stackless-dev/stackless". (cherry picked from commit c11af2f)

Replace "https://bitbucket.org/stackless-dev/stackless" by "https://github.com/stackless-dev/stackless". (cherry picked from commit 49c9417)

open() uses non-binary by default. The equivalent pkg_resources.resource_stream() method opens in binary mode.

make SimpleXMLRPCServer.SimpleXMLRPCServer.register_function as decor…

87fef8d

…ator

zhangyangyu requested a review from briancurtin February 22, 2017 05:35

the-knights-who-say-ni added the CLA signed label Feb 22, 2017

add news entry

fde883e

zhangyangyu changed the title ~~bpo-7769: enable SimpleXMLRPCServer.SimpleXMLRPCServer.register_function used as decorator~~ bpo-7769: enable SimpleXMLRPCServer.SimpleXMLRPCDispatcher.register_function used as decorator Feb 22, 2017

zhangyangyu changed the title ~~bpo-7769: enable SimpleXMLRPCServer.SimpleXMLRPCDispatcher.register_function used as decorator~~ bpo-7769: enable xmlrpc.server.SimpleXMLRPCDispatcher.register_function used as decorator Feb 22, 2017

zhangyangyu added 2 commits February 22, 2017 14:04

alter NEWS

c0c01b0

change versionadded to versionchanged

d4104eb

serhiy-storchaka approved these changes Feb 28, 2017

View reviewed changes

zhangyangyu added 3 commits February 28, 2017 15:25

remove outdated doc

51a3353

Merge branch 'master' into xml-register_function

a1e0ba5

fix style

a19d74e

serhiy-storchaka approved these changes Feb 28, 2017

View reviewed changes

berkerpeksag reviewed Feb 28, 2017

View reviewed changes

zhangyangyu added 3 commits February 28, 2017 16:09

fix style nits

eaa27d9

adjust phrase

8a3f4c3

fix wording

391b140

serhiy-storchaka approved these changes Feb 28, 2017

View reviewed changes

zhangyangyu merged commit 267b9d2 into python:master Feb 28, 2017

zhangyangyu deleted the xml-register_function branch February 28, 2017 09:13

akruis added a commit to akruis/cpython that referenced this pull request Jan 22, 2020

Stackless issue python#231: Update Stackless related bitbucket.org URLs

49c9417

Replace "https://bitbucket.org/stackless-dev/stackless" by "https://github.com/stackless-dev/stackless".

jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023

docs/migration: explicitly set binary mode for open() (python#231)

e7c4bae

open() uses non-binary by default. The equivalent pkg_resources.resource_stream() method opens in binary mode.

Uh oh!

Conversation

zhangyangyu commented Feb 22, 2017

Uh oh!

zhangyangyu commented Feb 22, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhangyangyu Feb 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhangyangyu commented Feb 28, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zhangyangyu Feb 28, 2017 •

edited

Loading